Differential D20946

[EPubGenerator] Reduce nesting level in loop
ClosedPublic
Actions

Authored by bruns on May 1 2019, 10:53 PM.

Details

Reviewers
ngraham
Group Reviewers
Okular
Commits
R223:f7fbbf769be3: [EPubGenerator] Reduce nesting level in loop
Summary

The loop body is skipped when epub_it_get_curr(it) is invalid.
Make it more obvious there is no more code executed in this case.

Test Plan

no functional changes

Diff Detail

Repository
R223 Okular
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.May 1 2019, 10:53 PM
Restricted Application added a project: Okular. · View Herald TranscriptMay 1 2019, 10:53 PM
Restricted Application added a subscriber: okular-devel. · View Herald Transcript
bruns requested review of this revision.May 1 2019, 10:53 PM
ngraham accepted this revision.May 2 2019, 6:13 PM
This revision is now accepted and ready to land.May 2 2019, 6:13 PM
Closed by commit R223:f7fbbf769be3: [EPubGenerator] Reduce nesting level in loop (authored by bruns). · Explain WhyMay 2 2019, 6:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mgenerators/epub/converter.cpp (11 lines)

Diff 57392

View Options

generators/epub/converter.cpp

Loading...