Differential D2086

Restore asynchronous QML object incubation in krunner
ClosedPublic
Actions

Authored by davidedmundson on Jul 4 2016, 3:42 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R871:0cec97bd9d11: Restore asynchronous QML object incubation in krunner
R120:0cec97bd9d11: Restore asynchronous QML object incubation in krunner
Summary

Using KDeclrative::QmlObject::rootObject before it's created blocks the
thread until it finishes so that code always "works" - but displays a
warning and is slower.

We now no longer get a warning on startup.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 4941.Jul 4 2016, 3:42 PM
davidedmundson retitled this revision from to Restore asynchronous QML object incubation in krunner.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJul 4 2016, 3:42 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Jul 4 2016, 3:48 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Jul 4 2016, 3:48 PM
Closed by commit R120:0cec97bd9d11: Restore asynchronous QML object incubation in krunner (authored by davidedmundson). · Explain WhyJul 5 2016, 12:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkrunner/view.cpp (5 lines)

Diff 4959

View Options

krunner/view.cpp

Loading...