Also consider member typedefs for determining the base class
ClosedPublic
Actions

Authored by vkrause on Apr 26 2019, 2:40 PM.

Details

Reviewers

Commits

Summary

This should allow us to avoid having to include (or copy) this into
KCalCore and KMime, as we no longer need to specialize the SuperClass
template.

PS: The unit test was written by Till 13 years ago, I have no idea who
Gerd and Rudi are, or why they are sub-classes of me.

Repository

R165 Akonadi

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

vkrause requested review of this revision.Apr 26 2019, 2:40 PM

I guess this is what you'll have to name your kids one day, otherwise the test will stop passing :-)

This revision is now accepted and ready to land.Apr 28 2019, 3:11 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			autotests/libs/itemhydratest.h (3 lines)
M			autotests/libs/itemhydratest.cpp (42 lines)
M			src/core/supertrait.h (17 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	57049	17a8855		Apr 26 2019, 2:40 PM	★	★
Diff 2	57206	4a8604d	R165:16a65caeb5fc1fee580a3448364a7e7138bf3b9a	Apr 29 2019, 5:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
f124c2d84330	76bebdb05eba	17a88550bff5	Volker Krause	Also consider member typedefs for determining the base class (Show More…)	Apr 26 2019, 2:40 PM