Differential D2082

ArchiveModel: check for ListJob errors
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 4 2016, 9:51 AM.

Details

Reviewers
rthomsen
Commits
R36:97eb1b3598dc: archivemodel: check for ListJob errors
Summary

If we abort opening a corrupt archive, the job gets an error code different than zero. We need to check this before trying to add entries to the model.

Test Plan

This fixes bug 361757 on Applications/16.04

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 4931.Jul 4 2016, 9:51 AM
elvisangelaccio retitled this revision from to ArchiveModel: check for ListJob errors.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
elvisangelaccio added a subscriber: kde-utils-devel.
elvisangelaccio added a comment.Jul 5 2016, 5:10 PM

I forgot that 16.04.3 is due on the 6th July instead of the 7th. Ragnar, do you have time to have a look at this patch? Otherwise I'll push it tomorrow...

elvisangelaccio added a comment.Jul 5 2016, 5:48 PM

Test file to reproduce the bug.

corrupted.rar36 KBDownload

rthomsen edited edge metadata.Jul 5 2016, 5:51 PM

Example corrupt rar archive:

testarchive-corrupt.rar556 BDownload

rthomsen accepted this revision.Jul 5 2016, 6:02 PM
rthomsen edited edge metadata.

Ship it!

This revision is now accepted and ready to land.Jul 5 2016, 6:02 PM
Closed by commit R36:97eb1b3598dc: archivemodel: check for ListJob errors (authored by elvisangelaccio). · Explain WhyJul 5 2016, 7:13 PM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio mentioned this in R36:97eb1b3598dc: archivemodel: check for ListJob errors.

Revision Contents
Changeset List

PathPackages
Mpart/archivemodel.cpp (20 lines)

Diff 4966

View Options

part/archivemodel.cpp

Loading...