Added missing options, new images, warnings and tips. Minor edits to be a little more specific.
Details
Details
Diff Detail
Diff Detail
- Repository
- R1012 Krita.org Documentation Website
- Branch
- blackbeard/selections
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 11195 Build 11213: arc lint + arc unit
Comment Actions
The image files should be run through optipng, but text-wise this looks fine to me...
@kamathraghavendra can you read this through and try to push it? Otherwise, I'll try tomorrow night.
Comment Actions
Hi @woltherav
Thank you for your kind review :)
I am sorry I should have read the images part of the manual carefully. I read about metadata but I skipped the part of optimizing PNG.
I have the better more compressed version now. But I don't know how to change the images here now.
Should I wait until it gets pushed and then update them?
There is also an small detail: I think in "Geometry" the part of "Global Coordinates" is not working. I have no idea how to use this feature.
Boud suggested me to read the code. But I decided to finish all the other things first. So I might updated later with a warning.
Comment Actions
As wolthera mentions please run the png image through pngquant as well as optipng once.
Some suggestions and pointers -
| reference_manual/tools/shape_selection.rst | ||
|---|---|---|
| 31 | I think we explain this drag type in next paragraph so, in my opinion it is not necessary here. | |
| 34 | There are two types of drag action while selecting with shape selection tool, | |
| 42 | Will it be good to put and before distortion? | |
| 45 | there is a typo "willnn" should be "will". The sentence can be like - "the following properties:" can be removed and it can be - "You can use this dashed box to do adjust the placement, scale, angle and distortion of the selected object." | |
| 54 | The dashed box is commonly called bounding box, so we can choose that term instead of dashed box, to make it familiar to new users. will it be possible to update it else where in the document? | |
| 54 | you can specify which click - by |mouseleft| directive just to be clear. | |
| 75 |
| |
| 100 | "The first set of set the fill of the stroke:" I think there is a missing word "buttons" here the sentence can be - The first set of buttons allows us to choose the fill of the stroke to be *None*, *Solid Color*, and *Gradient*. These same options exist for the fill of the shape, please refer to the following .. | |
| 107 | Sets the stroke cap and stroke corner style, this can be accessed by pressing the three dots button next to the thickness entry. | |
| 109 | Sets the line style of the stroke, ... | |
| 119 | This section is about the fill of the color that fills the shape. | |
| 121 | It is called as *solid color* in the tool tip so ti would be best to call it that, for consistency. Also I saw a commit which has hidden the pattern fill from the UI since it does not work properly, so I think we need to omit the pattern fill here | |
| 128 | As the name implies this type fills the shape with a gradient. It has the following options | |
| 135 | A menu for selecting a base gradient from a set of predefined gradient presets, which can be edited to our liking. | |
| 140 | You can create more stops just by clicking anywhere on the line. To select a stop |mouseleft} inside the triangle. To delete the stops, |mouseleft| drag them to left or right until the end of the line. | |
| 157 | I think they work, I just now tested it, so the warning is not required. | |
| 164 | Patterns are hidden in the new builds so I guess this warning is also not required, since there is no option in UI | |