Differential D20796

[Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI
ClosedPublic
Actions

Authored by ngraham on Apr 24 2019, 9:51 PM.

Details

Reviewers
GB_2
Group Reviewers
VDG
Plasma
Maniphest Tasks
T10586: Modernize widget configuration settings
Commits
R119:b8d753f4f00f: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI
Summary
  • Port to QQC2+Kirigami FormLayout
  • Adjust some strings to be more natural
  • Fix some incorrect strings when being an Activity pager rather than a Virtual Desktop pager
Test Plan

All features still work.

Virtual Desktops:

Activities:

Diff Detail

Repository
R119 Plasma Desktop
Branch
modernize-pager-settings-window (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11205
Build 11223: arc lint + arc unit
ngraham created this revision.Apr 24 2019, 9:51 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2019, 9:51 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 24 2019, 9:51 PM
ngraham updated this revision to Diff 56926.Apr 24 2019, 9:57 PM

Also correct category icon

GB_2 added a subscriber: GB_2.Apr 24 2019, 10:24 PM

Looks good UI-wise.

applets/pager/package/contents/ui/configGeneral.qml
136 ↗(On Diff #56926)

Default radio buttons should be at the top.

ngraham updated this revision to Diff 56941.Apr 25 2019, 2:27 AM
ngraham marked an inline comment as done.

Re-arrange radio buttons so the default one is on top

ngraham edited the summary of this revision. (Show Details)Apr 25 2019, 2:27 AM
ngraham edited the test plan for this revision. (Show Details)
GB_2 accepted this revision as: VDG, GB_2.Apr 25 2019, 7:05 PM

Perfect.

This revision is now accepted and ready to land.Apr 25 2019, 7:05 PM
Closed by commit R119:b8d753f4f00f: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI (authored by ngraham). · Explain WhyApr 25 2019, 7:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 56941

View Options

applets/pager/package/contents/config/config.qml

Loading...
View Options

applets/pager/package/contents/ui/configGeneral.qml

Loading...