Home
Phabricator
Search
Log In
Differential
D20647
[Purpose] Make it compile without foreach
Closed
Public
Actions
Authored by
mlaurent
on Apr 18 2019, 6:57 AM.
Edit Revision
Update Diff
Download Raw Diff
Edit Related Revisions...
Edit Parent Revisions
Edit Child Revisions
Edit Related Objects...
Edit Commits
Edit Tasks
Subscribe
Mute Notifications
Award Token
Flag For Later
Tags
Frameworks
Subscribers
kde-frameworks-devel
Details
Reviewers
dfaure
Commits
R495:c1939150503f: [Purpose] Make it compile without foreach
Summary
compile without foreach
NO_CHANGELOG
Test Plan
autotest ok
Diff Detail
Left (Diff 56492)
Right (Diff 56511)
Repository
R495 Purpose Library
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10982
Build 11000: arc lint + arc unit
Repository
R495 Purpose Library
Branch
compile_without_foreach (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10989
Build 11007: arc lint + arc unit
mlaurent
created this revision.
Apr 18 2019, 6:57 AM
Restricted Application
added a project:
Frameworks
.
·
View Herald Transcript
Apr 18 2019, 6:57 AM
Restricted Application
added a subscriber:
kde-frameworks-devel
.
·
View Herald Transcript
mlaurent
requested review of this revision.
Apr 18 2019, 6:57 AM
Harbormaster
completed remote builds in
B10982: Diff 56492
.
Apr 18 2019, 6:57 AM
mlaurent
edited the summary of this revision.
(Show Details)
Apr 18 2019, 6:57 AM
dfaure
requested changes to this revision.
Apr 18 2019, 7:25 AM
dfaure
added inline comments.
src/plugins/pastebin/pastebinplugin.cpp
50 ↗
(On Diff #56492)
const
This revision now requires changes to proceed.
Apr 18 2019, 7:25 AM
mlaurent
updated this revision to
Diff 56511
.
Apr 18 2019, 11:38 AM
Comment Actions
Add missing const
Harbormaster
completed remote builds in
B10989: Diff 56511
.
Apr 18 2019, 11:38 AM
dfaure
accepted this revision.
Apr 18 2019, 11:48 AM
This revision is now accepted and ready to land.
Apr 18 2019, 11:48 AM
Closed by commit
R495:c1939150503f: [Purpose] Make it compile without foreach
(authored by
mlaurent
).
·
Explain Why
Apr 18 2019, 12:02 PM
This revision was automatically updated to reflect the committed changes.