Differential D2058

Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages
ClosedPublic
Actions

Authored by kossebau on Jul 1 2016, 1:57 PM.

Details

Reviewers
boemann
Calligra-Devel-list
Commits
R8:9f1ebd6d901a: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages
Summary

Linking KI18n results in Qt translations being loaded on start. And
QXmlStreamReader, used internally by KoXmlDocument, returns translated error messages.
So running in a non-en locale still testing the english strings will fail.

Checking undocumented error strings is fragile already, so relying on a certain
translation context does not make things a lot worse.

Test Plan

Tests no longer fail with Qt translations installed and running in a non-en
locale.

Diff Detail

Repository
R8 Calligra
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau updated this revision to Diff 4887.Jul 1 2016, 1:57 PM
kossebau retitled this revision from to Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages.
kossebau updated this object.
kossebau edited the test plan for this revision. (Show Details)
kossebau added a reviewer: Calligra-Devel-list.
Restricted Application added projects: KEXI, Calligra: 3.0. · View Herald TranscriptJul 1 2016, 1:57 PM
boemann accepted this revision.Jul 2 2016, 5:59 AM
boemann added a reviewer: boemann.
boemann added a subscriber: boemann.

Was my idea on how to fix too so i agree

This revision is now accepted and ready to land.Jul 2 2016, 5:59 AM
Closed by commit R8:9f1ebd6d901a: Make TestXmlReader/TestXmlReaderWithoutSpaces handle translated error messages (authored by kossebau). · Explain WhyJul 2 2016, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4896

View Options

libs/odf/tests/TestXmlReader.cpp

Loading...
View Options

libs/odf/tests/TestXmlReaderWithoutSpaces.cpp

Loading...