Differential D2057

[autotest/integration] Add helper for waiting for a shown ShellClient
ClosedPublic
Actions

Authored by graesslin on Jul 1 2016, 7:56 AM.

Details

Reviewers

Group Reviewers

Plasma on Wayland
KWin

Commits

R108:cf3a1d295caa: [autotest/integration] Add helper for waiting for a shown ShellClient

Summary

Many tests create a Wayland window, render it and then wait till it's
created in KWin as a ShellClient. To reduce code duplication the test
helper provides helper methods to wait for the next ShellClient to be
shown and to directly render and wait for the window for that to be
shown.

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 4884.Jul 1 2016, 7:56 AM

graesslin retitled this revision from to [autotest/integration] Add helper for waiting for a shown ShellClient.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added reviewers: KWin, Plasma on Wayland.

Restricted Application added projects: Plasma on Wayland, KWin. · View Herald TranscriptJul 1 2016, 7:56 AM

Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

bshah accepted this revision.Jul 1 2016, 8:00 AM

bshah added a reviewer: bshah.

This revision is now accepted and ready to land.Jul 1 2016, 8:00 AM

Closed by commit R108:cf3a1d295caa: [autotest/integration] Add helper for waiting for a shown ShellClient (authored by graesslin). · Explain WhyJul 1 2016, 8:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/integration/decoration_input_test.cpp (10 lines)
M			autotests/integration/dont_crash_cancel_animation.cpp (15 lines)
M			autotests/integration/dont_crash_no_border.cpp (10 lines)
M			autotests/integration/kwin_wayland_test.h (13 lines)
M			autotests/integration/lockscreen.cpp (9 lines)
M			autotests/integration/maximize_test.cpp (16 lines)
M			autotests/integration/move_resize_window_test.cpp (70 lines)
M			autotests/integration/plasma_surface_test.cpp (18 lines)
M			autotests/integration/quick_tiling_test.cpp (40 lines)
M			autotests/integration/struts_test.cpp (36 lines)
M			autotests/integration/test_helpers.cpp (28 lines)
M			autotests/integration/touch_input_test.cpp (9 lines)
M			autotests/integration/transient_placement.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4884	513878e		Jul 1 2016, 7:56 AM	★	★
Diff 2	4885	513878e	rKWINcf3a1d295caafaaf2c57d385efeb2758195419bd	Jul 1 2016, 7:56 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
b138253d9444	19ba8d324548	513878e20df4	Martin Gräßlin	[autotest/integration] Add helper for waiting for a shown ShellClient (Show More…)	Jul 1 2016, 7:54 AM