Check if the filename is empty when user wants to save the file
ClosedPublic

Authored by yurchor on Apr 14 2019, 9:00 AM.

Details

Summary

KEduVocDocument default name is empty and that's preventing user to save the new document when the window closed and KWordQuiz asks if the user want sto save the document.

Test Plan
  1. Open KWordQuiz window, type something in the first column.
  2. Click on the close window button or press Ctrl+Q.
  3. Click on "Save".
  4. The Save dialog should be opened (before the patch, KWQ just did nothing and closed the confirmation window).

Diff Detail

Repository
R338 KWordQuiz
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
yurchor created this revision.Apr 14 2019, 9:00 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 14 2019, 9:00 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
yurchor requested review of this revision.Apr 14 2019, 9:00 AM
aacid added a subscriber: aacid.Apr 14 2019, 4:31 PM

there's 3 more checks for "Untitled" in that file. Could you check if those need updating too?

As far as i can see from a quick lool the check for Untitled makes no sense and should be simply removed/replaced with the one you're doing.

All the mentions of Untitled in kwordquiz are checking if it has that value, noone sets it.

And there is no mention of Untitled in keduvocdocument at all.

yurchor updated this revision to Diff 56223.Apr 14 2019, 4:38 PM

Get rid of "Untitled" because KEduVocDocument uses empty names for the new documents

aacid accepted this revision.Apr 14 2019, 5:03 PM

put it on the stable branch too?

This revision is now accepted and ready to land.Apr 14 2019, 5:03 PM
This revision was automatically updated to reflect the committed changes.