Differential D2051

[Panel Containment] Fix containment size for right-to-left-layout
ClosedPublic
Actions

Authored by broulik on Jun 29 2016, 9:34 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:ad7184b04ceb: [Panel Containment] Fix containment size for right-to-left-layout
Summary

The X offset was adjusted for when in right-to-left mode but it didn't take into account that we do not have a toolbox when widgets are locked, pushing applets out the right side of the screen when widgets are locked.

Test Plan

left-to-right, unlocked: works
left-to-right, locked: works
right-to-left, unlocked: works
right-to-left, locked: works now, did not work before

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik updated this revision to Diff 4863.Jun 29 2016, 9:34 PM
broulik retitled this revision from to [Panel Containment] Fix containment size for right-to-left-layout.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 29 2016, 9:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik updated this revision to Diff 4864.Jun 29 2016, 9:38 PM
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
davidedmundson accepted this revision.Jun 29 2016, 9:46 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Jun 29 2016, 9:46 PM
Closed by commit R119:ad7184b04ceb: [Panel Containment] Fix containment size for right-to-left-layout (authored by broulik). · Explain WhyJun 30 2016, 8:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4864

View Options

containments/panel/contents/ui/main.qml

Loading...