Differential D2039

Fix build errors and linker warnings on OS X
ClosedPublic
Actions

Authored by qi437103 on Jun 28 2016, 6:38 PM.

Details

Reviewers
apol
rjvbb
Group Reviewers
KDevelop
Commits
R32:c43a511b9858: Fix build errors and linker warnings on OS X
Summary

Fix compile errors and linker warnings in the debuggers subdirectory when build on OS X.

  • Use #include <signal.h> rather than #include "sys/sys/signal.h"
  • Fix visibility argument settings on kdevdebuggercommon to avoid linker warnings

Detailed discuss can be found on mailing list 1 2

Test Plan

it now builds without any errors or linker warnings, tested by René

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
qi437103 updated this revision to Diff 4817.Jun 28 2016, 6:38 PM
qi437103 retitled this revision from to Fix build errors and linker warnings on OS X.
qi437103 updated this object.
qi437103 edited the test plan for this revision. (Show Details)
qi437103 added a reviewer: apol.
qi437103 added a subscriber: rjvbb.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 28 2016, 6:38 PM
rjvbb accepted this revision.Jun 28 2016, 7:37 PM
rjvbb added a reviewer: rjvbb.

LGTM.

The comment in the CMake file is very complete; the 1st three lines seem sufficient to me (if the commit message will contain a reference to this RR).

This revision is now accepted and ready to land.Jun 28 2016, 7:37 PM
Closed by commit R32:c43a511b9858: Fix build errors and linker warnings on OS X (authored by qi437103). · Explain WhyJun 28 2016, 7:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 4819

View Options

debuggers/common/CMakeLists.txt

Loading...
View Options

debuggers/common/midebugger.cpp

Loading...