[Folder View] Use a more reasonable minimum cell width
ClosedPublic

Authored by ngraham on Apr 7 2019, 11:38 PM.

Details

Summary

With the goal of making Folder View items' labels more legible,
78da28e7ab7d51e46fa26788d4890b692996ad36 increased the minimum cell
width, resulting in each cell being much wider when icon sizes are small.

The goal was achieved, but the change went a bit too far and people have
understandably complained about the width being too high and looking silly
when the icon size is small, especially for items with very short labels.

This patch reduces the minimum width a bit to improve the situation.

I still suspect that we may need to add a slider to control the label width just like
the one Dolphin has (see D20370), but hopefully this patch should improve the
situation for people using the LTS release, and reduce the pressure for yet
another user-facing setting.

BUG: 403412
FIXED-IN: 5.12.9

Test Plan

Smallest icon size:


Small-medium icon size:

Medium icon size:

[No change for larger icon sizes]

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Apr 7 2019, 11:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 7 2019, 11:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Apr 7 2019, 11:38 PM
ngraham edited the summary of this revision. (Show Details)Apr 7 2019, 11:39 PM
ngraham edited the summary of this revision. (Show Details)Apr 8 2019, 3:35 AM
hein accepted this revision.Apr 8 2019, 9:29 AM
This revision is now accepted and ready to land.Apr 8 2019, 9:29 AM
This revision was automatically updated to reflect the committed changes.