Rollback changes to CollectionReferenceManager on DB rollback
AbandonedPublic
Actions

Authored by dvratil on Apr 7 2019, 7:42 AM.

Details

Reviewers

Summary

This is one of the in-memory caches that must be rolled-back during a
database transaction rollback to preserve consistent state of the
whole system.

Test Plan

Builds and looks sensible, but this is hard to reproduce or even test,
so I haven't actually tried this.

Repository

R165 Akonadi

Branch

arcpatch-D20337

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 10559
Build 10577: arc lint + arc unit

Restricted Application added a subscriber: kde-pim. · View Herald Transcript

dvratil requested review of this revision.Apr 7 2019, 7:42 AM

dfaure requested changes to this revision.Apr 7 2019, 8:00 AM

dfaure added inline comments.

src/server/storage/collectionstatistics.cpp
215 ↗	(On Diff #55627)	This should never be needed. http://eel.is/c++draft/class.copy.elision#3
src/shared/akscopeguard.h
35	Is there any situation where this might be null?

This revision now requires changes to proceed.Apr 7 2019, 8:00 AM

Address review comments

Unfuckup

dfaure requested changes to this revision.Apr 7 2019, 8:45 AM

dfaure added inline comments.

src/server/handler/collectionmodifyhandler.cpp
246	It sounds like this only undoes referencing, not de-referencing?

This revision now requires changes to proceed.Apr 7 2019, 8:45 AM

I found a better fix: remove collection referencing.

			Path	Packages
M			autotests/shared/CMakeLists.txt (1 line)
P			autotests/shared/akscopeguardtest.cpp (46 lines) Copied from src/server/storage/transaction.cpp
M			src/server/handler/collectionmodifyhandler.cpp (11 lines)
M			src/server/storage/transaction.h (2 lines)
P			src/server/storage/transaction.cpp (5 lines) Copied to multiple locations: autotests/shared/akscopeguardtest.cpp src/shared/akscopeguard.h
P			src/shared/akscopeguard.h (47 lines) Copied from src/server/storage/transaction.cpp

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55627	d2529db		Apr 7 2019, 7:42 AM	★	★
Diff 2	55633	cf9c714	Address review comments	Apr 7 2019, 8:37 AM	★	★
Diff 3	55634	d2529db	Unfuckup	Apr 7 2019, 8:42 AM	★	★