Differential D20296

Port away from SortableList::insertSorted
ClosedPublic
Actions

Authored by vkrause on Apr 6 2019, 9:32 AM.

Details

Reviewers
dvratil
Commits
R172:aade860bbbc7: Port away from SortableList::insertSorted

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 6 2019, 9:32 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2019, 9:32 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 6 2019, 9:32 AM
dvratil requested changes to this revision.Apr 6 2019, 9:01 PM
dvratil added a subscriber: dvratil.

Looks OK, but could you factor it out into a function too, please?

This revision now requires changes to proceed.Apr 6 2019, 9:01 PM
vkrause updated this revision to Diff 55626.Apr 7 2019, 7:19 AM

Factor out set insertion helper method.

dvratil accepted this revision.Apr 7 2019, 7:40 AM
This revision is now accepted and ready to land.Apr 7 2019, 7:40 AM
Closed by commit R172:aade860bbbc7: Port away from SortableList::insertSorted (authored by vkrause). · Explain WhyApr 7 2019, 7:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/recurrence.cpp (8 lines)
Msrc/recurrencehelper_p.h (9 lines)

Diff 55628

View Options

src/recurrence.cpp

Loading...
View Options

src/recurrencehelper_p.h

Loading...