Differential D20294

Port away from SortableList::sortUnique
ClosedPublic
Actions

Authored by vkrause on Apr 6 2019, 9:26 AM.

Details

Reviewers
dvratil
Commits
R172:43478324c22e: Port away from SortableList::sortUnique
R172:c398c866c7e6: Fix arc landing an outdated version of D20294

Diff Detail

Repository
R172 KCalendar Core
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 6 2019, 9:26 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 6 2019, 9:26 AM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 6 2019, 9:26 AM
dvratil added a subscriber: dvratil.Apr 6 2019, 10:21 AM

I think this is repeated enough times to warrant a dedicated helper function (sortAndRemoveDuplicates(Container &) ?).

dvratil requested changes to this revision.Apr 6 2019, 10:21 AM
This revision now requires changes to proceed.Apr 6 2019, 10:21 AM
vkrause updated this revision to Diff 55541.Apr 6 2019, 12:05 PM

Move to helper method for sort/unique.

dvratil accepted this revision.Apr 6 2019, 12:26 PM

Thanks!

This revision is now accepted and ready to land.Apr 6 2019, 12:26 PM
vkrause updated this revision to Diff 55548.Apr 6 2019, 12:50 PM

Fix the helper method.

dvratil accepted this revision.Apr 6 2019, 2:38 PM
Closed by commit R172:43478324c22e: Port away from SortableList::sortUnique (authored by vkrause). · Explain WhyApr 6 2019, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/recurrence.cpp (59 lines)
Msrc/recurrencerule.cpp (6 lines)

Diff 55567

View Options

src/recurrence.cpp

Loading...
View Options

src/recurrencerule.cpp

Loading...