Differential D20252

Improve error diagnostics when input or output files are missing
ClosedPublic
Actions

Authored by vkrause on Apr 4 2019, 4:29 PM.

Details

Reviewers
dvratil
Commits
R174:a1beb58e2bab: Improve error diagnostics when input or output files are missing
Summary

qFatal results in [c]make just showing "core dumped", exiting with a
non-zero error code shows the actual error message instead.

Diff Detail

Repository
R174 KContacts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vkrause created this revision.Apr 4 2019, 4:29 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 4 2019, 4:29 PM
Restricted Application added a subscriber: kde-pim. · View Herald Transcript
vkrause requested review of this revision.Apr 4 2019, 4:29 PM
dvratil accepted this revision.Apr 4 2019, 4:58 PM
dvratil added a subscriber: dvratil.

Hmm, shouldn't there also be return 0 at the end of the main() function?

This revision is now accepted and ready to land.Apr 4 2019, 4:58 PM
vkrause updated this revision to Diff 55430.Apr 4 2019, 5:21 PM

Also return 0 at the end of main().

dvratil accepted this revision.Apr 5 2019, 7:04 AM
Closed by commit R174:a1beb58e2bab: Improve error diagnostics when input or output files are missing (authored by vkrause). · Explain WhyApr 5 2019, 12:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/generator/main.cpp (9 lines)

Diff 55466

View Options

src/generator/main.cpp

Loading...