Remove "Open" button and make notification clickable instead
ClosedPublic
Actions

Authored by broulik on Apr 1 2019, 2:31 PM.

Details

Reviewers

Group Reviewers

Plasma
VDG

Commits

Summary

This makes for a cleaner notification appearance, especially since there's the thumbnail area below it.

Test Plan

Can click the entire notification now instead of having to click the "Open" button. Can also click the thumbnail as before.

Before:

After:

Repository

R166 Spectacle

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: Spectacle. · View Herald Transcript

broulik requested review of this revision.Apr 1 2019, 2:31 PM

broulik edited the test plan for this revision. (Show Details)Apr 1 2019, 2:37 PM

broulik edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Apr 1 2019, 3:35 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/SpectacleCore.cpp (13 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	55197			Apr 1 2019, 2:29 PM	★	★
Diff 2	55198			Apr 1 2019, 2:35 PM	★	★
Diff 3	55219	80c0a13	R166:50647fd52f08962571f25079dbdc3839681c0bbc	Apr 1 2019, 6:19 PM	★	★