Differential D20088

Simplify TerminalDisplay code
ClosedPublic
Actions

Authored by tcanabrava on Mar 28 2019, 11:35 AM.

Details

Reviewers
hindenburg
Group Reviewers
Konsole
Commits
R319:4cddc420e319: Simplify TerminalDisplay code

Diff Detail

Repository
R319 Konsole
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tcanabrava created this revision.Mar 28 2019, 11:35 AM
Restricted Application added a project: Konsole. · View Herald TranscriptMar 28 2019, 11:35 AM
Restricted Application added a subscriber: konsole-devel. · View Herald Transcript
tcanabrava requested review of this revision.Mar 28 2019, 11:35 AM
tcanabrava updated this revision to Diff 54979.Mar 28 2019, 11:40 AM
  • Use one liners where appropriate.
  • Remove sender() and QVariant() conversions
  • Declare + initialize, instead of setting the value later
  • Don't create unecessary temporaries
  • Extract code from huge function into a smaller one
tcanabrava retitled this revision from Use one liners where appropriate. to Simplify TerminalDisplay code .Mar 28 2019, 11:42 AM
tcanabrava added a reviewer: Konsole.
hindenburg accepted this revision.Mar 28 2019, 1:50 PM
hindenburg added a subscriber: hindenburg.

thanks

This revision is now accepted and ready to land.Mar 28 2019, 1:50 PM
Closed by commit R319:4cddc420e319: Simplify TerminalDisplay code (authored by tcanabrava, committed by hindenburg). · Explain WhyMar 28 2019, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/TerminalDisplay.h (7 lines)
Msrc/TerminalDisplay.cpp (119 lines)

Diff 54984

View Options

src/TerminalDisplay.h

Loading...
View Options

src/TerminalDisplay.cpp

Loading...