BUG: 405059
FIXED-IN:5.0.4
Details
Details
- Reviewers
habacker - Commits
- R261:c4a8edc6566b: Use a global printer object for all print jobs
Diff Detail
Diff Detail
- Repository
- R261 KMyMoney
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just a note: Printing a report as diagram prints in fact a table report, which may confuses user expecting to print a real diagram.
As a fix I see to disable print button in case a diagram is shown. Another options is to add diagram printing support in as separate commit. See https://cgit.kde.org/kmymoney.git/commit/?h=4.8-staging&id=2ac6eb5433f81111ae7206e84a2cfda50ddcfe7f for an example for the 4.8 branch.
| kmymoney/plugins/checkprinting/checkprinting.cpp | ||
|---|---|---|
| 37–38 | this (and 4 similiar ) includes are now obsolete and should be removed | |
Comment Actions
On implementing you may consider to design diagram printing with print preview in mind to avoid an additional required refactoring to get print preview support afterwards. Print preview support requires to perform the preview generating and real printing by a slot getting a pointer to a QPrinter instance e.g. slotPaintRequested(QPrinter *printer) , see https://doc.qt.io/Qt-5/qprintpreviewdialog.html#details for details.
Comment Actions
looks good otherwise
| kmymoney/kmymoneyutils.cpp | ||
|---|---|---|
| 42 ↗ | (On Diff #54783) | unrelated, looks to be added for another task. |
| 627 ↗ | (On Diff #54783) | This is also unrelated, please remove |
| kmymoney/plugins/checkprinting/checkprinting.json.cmake | ||
| 11 ↗ | (On Diff #54783) | patch contains unrelated additions, also some more locations below |
Comment Actions
| kmymoney/kmymoneyutils.cpp | ||
|---|---|---|
| 627 ↗ | (On Diff #54783) | arc played tricks on me 'again'. I hate it for that. Will use plain git to add to repo. |
Comment Actions
The -#include <QPrintDialog> is still missing in git and needs an additional fixup commit.
arc played tricks on me 'again'. I hate it for that. Will use plain git to add to repo.
It probably will be better with the gitlab migration. See "Gitlab Evaluation & Migration" thread in kde-devel@kde.org.