Change selectionrect
ClosedPublic

Authored by Murmele on Mar 22 2019, 10:35 PM.

Diff Detail

Repository
R262 LabPlot
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Murmele created this revision.Mar 22 2019, 10:35 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptMar 22 2019, 10:35 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Murmele requested review of this revision.Mar 22 2019, 10:35 PM

the selection box is hardly visible because the width of the pen is not considered. The rectangular needs to be adjusted in order to take the pen into account. Please check how this is done in WorksheetElementContainerPrivate::recalcShapeAndBoundingRect() where boundingRecangular is adjusted and containerShape is created - this logic we need to implement based on q->m_plotArea->graphicsItem()->boundingRect(), too.

Murmele updated this revision to Diff 55130.Mar 31 2019, 1:21 PM
asemke accepted this revision.Mar 31 2019, 1:29 PM
This revision is now accepted and ready to land.Mar 31 2019, 1:29 PM
This revision was automatically updated to reflect the committed changes.