Differential D19959

Fixed issue causing changed signal to be called with false argument
ClosedPublic
Actions

Authored by tigrang on Mar 21 2019, 11:48 PM.

Details

Reviewers
mlaurent
Commits
R123:0c76098e80c8: Fixed issue causing changed signal to be called with false argument
R123:ed3decc06e38: Fixed issue causing changed signal to be called with false argument
Summary

AdvanceConfig::changed signal is called with changed=false arguement when QGroupBox::clicked is called with checked=false causing the Apply button to remain disabled.

BUG: 403366

Test Plan
  1. Open SDDM settings
  2. Enable auto-login, save and close.
  3. Open SDDM settings again
  4. Uncheck auto-login

Apply button should now be enabled.
Same steps for Relogin after quit checkbox.

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Lint Skipped
Unit
Unit Tests Skipped
tigrang created this revision.Mar 21 2019, 11:48 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 21 2019, 11:48 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tigrang requested review of this revision.Mar 21 2019, 11:48 PM
tigrang edited the summary of this revision. (Show Details)Mar 21 2019, 11:57 PM
mlaurent accepted this revision.Mar 22 2019, 2:54 PM
mlaurent added a subscriber: mlaurent.

Good catch.
it's a bug in clazy.

Thanks
Do you have an commit access ?
or do you want that I commit for you ?

This revision is now accepted and ready to land.Mar 22 2019, 2:54 PM
tigrang added a comment.Mar 22 2019, 7:03 PM

I do not have commit access.

Can you commit for me, please?

Full Name: Tigran Gabrielyan
Email: tigrangab@gmail.com

Closed by commit R123:ed3decc06e38: Fixed issue causing changed signal to be called with false argument (authored by mlaurent). · Explain WhyMar 23 2019, 8:00 AM
This revision was automatically updated to reflect the committed changes.
ngraham added a subscriber: ngraham.Mar 24 2019, 4:16 PM

@mlaurent you didn't commit with with correct authorship information in the git author field. :(

Revision Contents
Changeset List

PathPackages
Msrc/advanceconfig.cpp (6 lines)

Diff 54521

View Options

src/advanceconfig.cpp

Loading...