Differential D19924

[TabBar] Update height when TabButtons are added dynamically
ClosedPublic
Actions

Authored by broulik on Mar 20 2019, 5:04 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R858:4cc5649da9b6: [TabBar] Update height when TabButtons are added dynamically
Summary

When using a Repeater with an asynchronously populated model TabBar fails to initially get a height.

Test Plan
  • Used a Repeater with ActivitiesModel wired up to a TabBar, previously didn't get a height, now it gets a height
  • KWin decoration KCM (which uses hardcoded TabButtons) still works fine

Diff Detail

Repository
R858 Qt Quick Controls 2: Desktop Style
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 20 2019, 5:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 20 2019, 5:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Mar 20 2019, 5:04 PM
mart accepted this revision.Apr 24 2019, 9:49 AM

the code looks super weird but yeah, seems needed :)

This revision is now accepted and ready to land.Apr 24 2019, 9:49 AM
Closed by commit R858:4cc5649da9b6: [TabBar] Update height when TabButtons are added dynamically (authored by broulik). · Explain WhyApr 24 2019, 9:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Morg.kde.desktop/TabBar.qml (3 lines)

Diff 56878

View Options

org.kde.desktop/TabBar.qml

Loading...