| Plasma |
This is useful for HighDPI otherwise a user needs to manually resize the
panel initially and/or after they change high DPI settings.
It also means if you adjust the font the panel will resize in proportion
to the contents resizing so it won't all end up cramped.
Reason it's a WIP, we need to:
It'll take as long to write that as this whole patch, so I want to check
we're happy with the idea first.
| No Linters Available |
| No Unit Test Coverage |
| shell/panelview.cpp | ||
|---|---|---|
| 1096 | why adding a new setter and getter that work in pixels? if something like that should be added, i wuld like just working with grid units. perhaps having the old thickness/setThickness etc that still accept sizes in pixels for compatibility and have new setUnitsThickness or whatever that accepts units? | |
| 1098 | in the scripting the m height is binded, not the width | |
anyways, i like the idea.
uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?)
uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?)
We /could/ but using a hybrid of two scaling systems seems like it'll get complex
| shell/panelview.cpp | ||
|---|---|---|
| 1096 | I can, but that just moves the conversion into being in multiple places instead of just 1. None of the other users of the thickness (the drag handles or working out the workspace screen area) want grid units. | |
| 1098 | you're right. int gridUnit = QFontMetrics(QGuiApplication::font()).boundingRect(QStringLiteral("M")).height();Will fix. | |
Can't remember what the state of this is, and the original code probably changed. Closing.