Differential D19778

[kitemmodels] make it compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Mar 15 2019, 6:53 AM.

Tags

Subscribers

kde-frameworks-devel

Details

Reviewers

Commits

R275:8327e0e0654a: [kitemmodels] make it compile without foreach

Summary

make it compile without foreach

Test Plan

autotest ok

Diff Detail

Repository

R275 KItemModels

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mlaurent created this revision.Mar 15 2019, 6:53 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 15 2019, 6:53 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Mar 15 2019, 6:53 AM

Harbormaster completed remote builds in B9615: Diff 53939.Mar 15 2019, 6:53 AM

dfaure requested changes to this revision.Mar 16 2019, 7:24 PM

dfaure added inline comments.

autotests/proxymodeltestsuite/modelspy.cpp
323	This is a good opportunity to remove this awful C cast. const QList<QVariantList> lst = *modelSpy;
src/kbreadcrumbselectionmodel.cpp
166–167	const
167–168	const

This revision now requires changes to proceed.Mar 16 2019, 7:24 PM

Add missing const, Remove C cast

Harbormaster completed remote builds in B9706: Diff 54073.Mar 17 2019, 10:49 AM

dfaure accepted this revision.Mar 17 2019, 7:55 PM

This revision is now accepted and ready to land.Mar 17 2019, 7:55 PM

Closed by commit R275:8327e0e0654a: [kitemmodels] make it compile without foreach (authored by mlaurent). · Explain WhyMar 18 2019, 5:54 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (2 lines)
M			autotests/proxymodeltestsuite/dynamictreemodel.cpp (23 lines)
M			autotests/proxymodeltestsuite/modeleventlogger.h (4 lines)
M			autotests/proxymodeltestsuite/modeleventlogger.cpp (4 lines)
M			autotests/proxymodeltestsuite/modelspy.h (4 lines)
M			autotests/proxymodeltestsuite/modelspy.cpp (10 lines)
M			autotests/proxymodeltestsuite/proxymodeltest.h (3 lines)
M			autotests/proxymodeltestsuite/proxymodeltest.cpp (7 lines)
M			autotests/test_model_helpers.h (2 lines)
M			src/kbreadcrumbselectionmodel.cpp (8 lines)
M			src/kcheckableproxymodel.cpp (6 lines)
M			src/kconcatenaterowsproxymodel.cpp (10 lines)
M			src/kdescendantsproxymodel.cpp (5 lines)
M			src/kextracolumnsproxymodel.cpp (6 lines)
M			src/klinkitemselectionmodel.cpp (2 lines)
M			src/kmodelindexproxymapper.cpp (6 lines)
M			src/krecursivefilterproxymodel.cpp (3 lines)
M			src/kselectionproxymodel.cpp (23 lines)
M			tests/proxymodeltestapp/breadcrumbswidget.cpp (4 lines)
M			tests/proxymodeltestapp/kreparentingproxymodel.cpp (8 lines)
M			tests/proxymodeltestapp/matchcheckingwidget.cpp (4 lines)
M			tests/proxymodeltestapp/modelcommanderwidget.cpp (2 lines)

Diff 54170

CMakeLists.txt

Loading...

autotests/proxymodeltestsuite/dynamictreemodel.cpp

Loading...

autotests/proxymodeltestsuite/modeleventlogger.h

Loading...

autotests/proxymodeltestsuite/modeleventlogger.cpp

Loading...

autotests/proxymodeltestsuite/modelspy.h

Loading...

autotests/proxymodeltestsuite/modelspy.cpp

Loading...

autotests/proxymodeltestsuite/proxymodeltest.h

Loading...

autotests/proxymodeltestsuite/proxymodeltest.cpp

Loading...

autotests/test_model_helpers.h

Loading...

src/kbreadcrumbselectionmodel.cpp

Loading...

src/kcheckableproxymodel.cpp

Loading...

src/kconcatenaterowsproxymodel.cpp

Loading...

src/kdescendantsproxymodel.cpp

Loading...

src/kextracolumnsproxymodel.cpp

Loading...

src/klinkitemselectionmodel.cpp

Loading...

src/kmodelindexproxymapper.cpp

Loading...

src/krecursivefilterproxymodel.cpp

Loading...

src/kselectionproxymodel.cpp

Loading...

tests/proxymodeltestapp/breadcrumbswidget.cpp

Loading...

tests/proxymodeltestapp/kreparentingproxymodel.cpp

Loading...

tests/proxymodeltestapp/matchcheckingwidget.cpp

Loading...

tests/proxymodeltestapp/modelcommanderwidget.cpp

Loading...