Don't set both font and pixel size in DigitalClock
ClosedPublic

Authored by davidedmundson on Jun 22 2016, 3:37 PM.

Details

Summary

Digital Clock sets fontSizeMode, this scales the font to fit between a
tiny size and a the given size.

In older Qt this used to be between 0 and pixel size - but because
Plasma.Components.Label already set the pointSize we had to set both.

In Qt 5.6 it seems to handle either type of font size being set, so we can
keep with just one.

Test Plan

Clock still scales to fill space
Clock still switches into compact mode if needed

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson retitled this revision from to Don't set both font and pixel size in DigitalClock.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 22 2016, 3:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas accepted this revision.Jun 23 2016, 10:01 AM
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.Jun 23 2016, 10:01 AM
This revision was automatically updated to reflect the committed changes.