Rename method name() to id()
ClosedPublic

Authored by vitalyf on Mar 13 2019, 2:06 PM.

Details

Summary

This makes sense because a string returned by this method is literally a
unique identifier that can be used either on a server side to identify a
data source or in an app itself for a lot of different purposes, e.g.,
for mapping data sources or performing some fast lookup by ID.
A method for getting a short user-visible name will be introduced in one
of the further revisions.

Diff Detail

Repository
R849 User Feedback Collection Framework
Lint
Lint Skipped
Unit
Unit Tests Skipped
vitalyf requested review of this revision.Mar 13 2019, 2:06 PM
vitalyf created this revision.

Overall I agree with this, just one minor nitpick.

src/provider/core/propertyratiosource.h
56

This one is referring to a different "name" I think.

vitalyf added inline comments.Mar 13 2019, 3:08 PM
src/provider/core/propertyratiosource.h
56

Agree.

src/provider/qml/qmlpropertyratiosource.h
48

This one should be changed back as well.

vitalyf updated this revision to Diff 53805.Mar 13 2019, 3:17 PM

Some accidentally renamed parameters restored back

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2019, 6:15 PM
Closed by commit R849:34ffffc6c922: Rename method name() to id() (authored by vitalyf, committed by vkrause). · Explain Why
This revision was automatically updated to reflect the committed changes.