Fix for showing argument hint tree on non-primary screen.
ClosedPublic

Authored by tfry on Mar 9 2019, 4:15 PM.

Details

Summary

If the texteditor window is on a secondary screen of a multi-screen desktop,
*and* the argument hint has not yet been shown, before, *and* it going to be
shown at a y-position above the top of the primary screen, the argument hint
will fail to show (because screenGeometry(this) will incorrectly refer to the
primary screen, then).

Thus, refer to the parent view, when determining screen geometry, as is
already done at other places in the code.

Diff Detail

Repository
R39 KTextEditor
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9384
Build 9402: arc lint + arc unit
tfry created this revision.Mar 9 2019, 4:15 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptMar 9 2019, 4:15 PM
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. · View Herald Transcript
tfry requested review of this revision.Mar 9 2019, 4:15 PM
cullmann accepted this revision.Mar 9 2019, 4:19 PM
cullmann added a subscriber: cullmann.

Given all other calls use m_parent->... for the screenGeometry call, this looks sane.

This revision is now accepted and ready to land.Mar 9 2019, 4:19 PM
tfry closed this revision.Mar 9 2019, 8:11 PM