Differential D19602

[KParts] Fix compilation for Qt 5.13
ClosedPublic
Actions

Authored by matthieugras on Mar 7 2019, 10:23 PM.

Details

Reviewers
apol
mlaurent
Commits
R306:3f3c760d7f52: [KParts] Fix compilation for Qt 5.13
Summary

Method is deprecated in Qt 5.13

Test Plan

Compiles

Diff Detail

Repository
R306 KParts
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
matthieugras created this revision.Mar 7 2019, 10:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 7 2019, 10:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
matthieugras requested review of this revision.Mar 7 2019, 10:23 PM
apol accepted this revision.Mar 8 2019, 11:21 AM
apol added a subscriber: apol.

That's a weird new API...

This revision is now accepted and ready to land.Mar 8 2019, 11:21 AM
mlaurent accepted this revision.Mar 12 2019, 7:52 AM
mlaurent added a subscriber: mlaurent.

Could you commit it ?:)

mlaurent added a comment.Mar 15 2019, 5:56 AM

Ping ???? do you want that we commit for you ?
Otherwise I will do it as I need this patch.

matthieugras added a comment.Mar 15 2019, 12:10 PM
In D19602#431385, @mlaurent wrote:

Ping ???? do you want that we commit for you ?
Otherwise I will do it as I need this patch.

Yes please, go ahead

Closed by commit R306:3f3c760d7f52: [KParts] Fix compilation for Qt 5.13 (authored by matthieugras, committed by mlaurent). · Explain WhyMar 15 2019, 9:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/browserrun.cpp (2 lines)

Diff 53976

View Options

src/browserrun.cpp

Loading...