This fixes jobs sending unmodified attributes, potentially overwriting
changes made elsewhere.
Port Collection and Tag to use AttributeStorage.
Item will be for a separate commit.
This fixes jobs sending unmodified attributes, potentially overwriting
changes made elsewhere.
Port Collection and Tag to use AttributeStorage.
Item will be for a separate commit.
All tests pass.
No Linters Available |
No Unit Test Coverage |
Buildable 9230 | |
Build 9248: arc lint + arc unit |
src/core/attributestorage_p.h | ||
---|---|---|
61 ↗ | (On Diff #53248) | What is the benefit of std::set<T> over a QSet<T> here? I don't mind using it, I'm just curious why you preferred it over QSet. |
src/core/jobs/tagfetchjob.cpp | ||
155 ↗ | (On Diff #53248) | You already reset the changelog in parseTagFetchResult(), no need to do it here again. |