Factorize attribute handling into new AttributeStorage class.
ClosedPublic
Actions

Authored by dfaure on Mar 5 2019, 10:26 PM.

Details

Reviewers

dvratil

Commits

Summary

This fixes jobs sending unmodified attributes, potentially overwriting
changes made elsewhere.

Port Collection and Tag to use AttributeStorage.
Item will be for a separate commit.

Test Plan

All tests pass.

Repository

R165 Akonadi

Branch

attribute_storage_for_tags

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 9231
Build 9249: arc lint + arc unit

dfaure requested review of this revision.Mar 5 2019, 10:26 PM

dvratil requested changes to this revision.Mar 6 2019, 11:55 AM

dvratil added inline comments.

src/core/attributestorage_p.h
62	What is the benefit of `std::set<T>` over a `QSet<T>` here? I don't mind using it, I'm just curious why you preferred it over `QSet`.
src/core/jobs/tagfetchjob.cpp
155 ↗	(On Diff #53248)	You already reset the changelog in `parseTagFetchResult()`, no need to do it here again.

This revision now requires changes to proceed.Mar 6 2019, 11:55 AM

src/core/attributestorage_p.h
62	A hash table for just a few elements is overkill (memory-wise).
src/core/jobs/tagfetchjob.cpp
155 ↗	(On Diff #53248)	Ah indeed -- I added that later.

Remove resetChangeLog in tagfetchjob.cpp

Remove now-unused include in tagfetchjob.cpp

Thanks!

This revision is now accepted and ready to land.Mar 6 2019, 6:21 PM

		Path
M		autotests/libs/protocolhelpertest.cpp (1 line)
M		autotests/libs/tagtest.cpp (61 lines)
M		src/core/CMakeLists.txt (1 line)
A	M	src/core/attributestorage.cpp (137 lines)
A	M	src/core/attributestorage_p.h (67 lines)
M		src/core/collection.h (12 lines)
M		src/core/collection.cpp (32 lines)
M		src/core/collection_p.h (16 lines)
M		src/core/jobs/collectionmodifyjob.cpp (8 lines)
M		src/core/jobs/tagmodifyjob.cpp (12 lines)
M		src/core/protocolhelper.cpp (13 lines)
M		src/core/protocolhelper_p.h (2 lines)
M		src/core/tag.h (12 lines)
M		src/core/tag.cpp (32 lines)
M		src/core/tag_p.h (15 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53248	9cac95e		Mar 5 2019, 10:26 PM	★	★
Diff 2	53269	9cac95e	Remove resetChangeLog in tagfetchjob.cpp	Mar 6 2019, 12:04 PM	★	★
Diff 3	53270	9cac95e	Remove now-unused include in tagfetchjob.cpp	Mar 6 2019, 12:04 PM	★	★