Differential D19540

Verify that there is no scene windows when Scene is about to be destroyed
ClosedPublic
Actions

Authored by zzag on Mar 5 2019, 12:45 PM.

Details

Reviewers
davidedmundson
Group Reviewers
KWin
Commits
R108:456c65fc19eb: Verify that there is no scene windows when Scene is about to be destroyed
Summary

When ~Scene is called, it's not guaranteed that backend is still valid
or that there is current opengl context. So, generally speaking,
deleting scene windows in ~Scene is a bad idea.

It's okay not to delete scene windows in ~Scene because current
implementation of Compositor::finish ensures that they don't last longer
than the scene.

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Mar 5 2019, 12:45 PM
Restricted Application added a project: KWin. · View Herald TranscriptMar 5 2019, 12:45 PM
Restricted Application added a subscriber: kwin. · View Herald Transcript
zzag requested review of this revision.Mar 5 2019, 12:45 PM
zzag edited the summary of this revision. (Show Details)Mar 5 2019, 12:47 PM
davidedmundson accepted this revision.Mar 5 2019, 1:16 PM
This revision is now accepted and ready to land.Mar 5 2019, 1:16 PM
Closed by commit R108:456c65fc19eb: Verify that there is no scene windows when Scene is about to be destroyed (authored by zzag). · Explain WhyMar 5 2019, 1:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mscene.cpp (2 lines)

Diff 53204

View Options

scene.cpp

Loading...