| davidedmundson |
| KDE Telepathy |
The placeholder ends with a decimal URL index. The substitution is an incremental pass from zero index, so when the placeholder is substituted back to URL the replacing code matches incomplete index and we got a messed URLs.
E.g. we replace placeholder #K#T#P1 and it actually mess up #K#T#P10 and #K#T#P11
Add a end marker to the placeholder scheme to never mess URL.
An alternative solution is to reverse the backward substitutions but meh. :)
BUG: 384968
FIXED-IN: 18.12.3
I took the testcase from the bugreport.
Test message:
Test http://01.org/ http://02.org/ http://03.org/ http://04.org/ http://05.org/ http://06.org/ http://07.org/ http://08.org/ http://09.org/ http://10.org/ http://11.org/ http://12.org/ http://13.org/ http://14.org/
What KDE Telepathy used to display:
Test http://01.org/ http://02.org/ http://03.org/ http://04.org/ http://05.org/ http://06.org/ http://07.org/ http://08.org/ http://09.org/ http://10.org/ http://02.org/0 http://02.org/1 http://02.org/2 http://02.org/3
What KTp displays with the fix:
Test http://01.org/ http://02.org/ http://03.org/ http://04.org/ http://05.org/ http://06.org/ http://07.org/ http://08.org/ http://09.org/ http://10.org/ http://11.org/ http://12.org/ http://13.org/ http://14.org/
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |