Differential D19437

[knewstuff] Remove qt5.13 deprecated method
ClosedPublic
Actions

Authored by mlaurent on Mar 1 2019, 6:14 AM.

Details

Reviewers
dfaure
Commits
R304:f7fbcc13f518: [knewstuff] Remove qt5.13 deprecated method
Summary

remove deprecated method

Test Plan

autotest ok

Diff Detail

Repository
R304 KNewStuff
Branch
remove_deprecated_qt5.13 (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 9115
Build 9133: arc lint + arc unit
mlaurent created this revision.Mar 1 2019, 6:14 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 1 2019, 6:14 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
mlaurent requested review of this revision.Mar 1 2019, 6:14 AM
dfaure requested changes to this revision.Mar 1 2019, 8:33 AM
dfaure added inline comments.
src/core/installation.cpp
575 ↗(On Diff #52879)

This should test the exit status too. I think that's the whole point of this change in Qt?

I guess the best way is

if (status == crashed) 
   qCCritical "we crashed on the moon, good luck telling the families"
else if (exitcode)
  ...
This revision now requires changes to proceed.Mar 1 2019, 8:33 AM
mlaurent updated this revision to Diff 53049.Mar 3 2019, 9:44 AM

Use exitstatus

dfaure accepted this revision.Mar 3 2019, 10:08 AM
This revision is now accepted and ready to land.Mar 3 2019, 10:08 AM
Closed by commit R304:f7fbcc13f518: [knewstuff] Remove qt5.13 deprecated method (authored by mlaurent). · Explain WhyMar 3 2019, 10:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)
Msrc/core/installation.cpp (8 lines)

Diff 53049

View Options

CMakeLists.txt

Loading...
View Options

src/core/installation.cpp

Loading...