create-abi-dump: Do not break for library, that don't have a SONAME.

Authored by knauss on Feb 28 2019, 9:58 AM.



KDED exports libraries, that don't have a SONAME (properly a internal
library). Make create-abi-dump robust to handle those cases.

Test Plan

Please revert e46a05908d02ca253e8dfbb55905b14f2730eca7 afterwards, to find more issues.

Diff Detail

R857 CI System Tooling
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
knauss requested review of this revision.Feb 28 2019, 9:58 AM
knauss created this revision.
bcooksley added inline comments.Feb 28 2019, 10:04 AM

Won't this still fail, as it will still continue to line 207?

knauss marked an inline comment as done.Feb 28 2019, 11:38 AM
knauss added inline comments.

nope"SONAME") will be None in that case, but this is valid content for line 207.

The issue before was that the complete regex does not match the case "" and than relib was None. Now the regex matches and relib is a valid match.

And I tested this patch for kded master and it does not break the build anymore. Still failing to create an ABI dump, as no headers are exported, but that is a different story.

bcooksley accepted this revision.Mar 1 2019, 7:56 PM
This revision is now accepted and ready to land.Mar 1 2019, 7:56 PM
This revision was automatically updated to reflect the committed changes.