KDED exports libraries, that don't have a SONAME (properly a internal
library). Make create-abi-dump robust to handle those cases.
Details
Details
- Reviewers
bcooksley - Maniphest Tasks
- T3689: Add abi compliance checker to CI
- Commits
- R857:fccc4a4a2033: create-abi-dump: Do not break for library, that doesn't have a SONAME.
Please revert e46a05908d02ca253e8dfbb55905b14f2730eca7 afterwards, to find more issues.
Diff Detail
Diff Detail
- Repository
- R857 CI System Tooling
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| helpers/create-abi-dump.py | ||
|---|---|---|
| 204 | Won't this still fail, as it will still continue to line 207? | |
| helpers/create-abi-dump.py | ||
|---|---|---|
| 204 | nope relib.group("SONAME") will be None in that case, but this is valid content for line 207. The issue before was that the complete regex does not match the case "libFoo.so" and than relib was None. Now the regex matches and relib is a valid match. And I tested this patch for kded master and it does not break the build anymore. Still failing to create an ABI dump, as no headers are exported, but that is a different story. | |