[Kconfig] Compile without foreach
ClosedPublic
Actions

Authored by mlaurent on Feb 26 2019, 6:04 AM.

Details

Reviewers

dfaure

Commits

R237:38b51667b5ba: [Kconfig] Compile without foreach

Summary

compile without foreach

Test Plan

Unittest Ok as previously

Repository

R237 KConfig

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

mlaurent requested review of this revision.Feb 26 2019, 6:04 AM

mlaurent retitled this revision from Compile without foreach to [Kconfig] Compile without foreach.Feb 26 2019, 12:59 PM

Did you check that unittests still pass? (please mention this in the "Test Plan:" field of the commit when using arc diff)

src/core/ksharedconfig.cpp
93	This looks like a poor man's qAsConst. Would this work with for (auto cfg : qAsConst(*list)) { ? (not sure)

This revision now requires changes to proceed.Feb 27 2019, 11:32 PM

Fixed code as requested by David

This revision is now accepted and ready to land.Mar 2 2019, 10:24 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			CMakeLists.txt (1 line)
M			autotests/kconfigtest.cpp (24 lines)
M			src/core/kauthorized.cpp (2 lines)
M			src/core/kconfig.cpp (17 lines)
M			src/core/kconfiggroup.h (7 lines)
M			src/core/kconfigini.cpp (2 lines)
M			src/core/kcoreconfigskeleton.cpp (6 lines)
M			src/core/kdesktopfile.cpp (14 lines)
M			src/core/ksharedconfig.cpp (2 lines)
M			src/gui/kconfigloader.cpp (7 lines)
M			src/kconf_update/kconf_update.cpp (18 lines)
M			src/kconf_update/kconfigutils.cpp (2 lines)
M			src/kconfig_compiler/kconfig_compiler.cpp (11 lines)
M			src/kreadconfig/kreadconfig.cpp (4 lines)
M			src/kreadconfig/kwriteconfig.cpp (4 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52579	2cdcd4f		Feb 26 2019, 6:04 AM	★	★
Diff 2	52808	2cdcd4f	Fixed code as requested by David	Feb 28 2019, 12:20 PM	★	★
Diff 3	53040	71abd43	R237:38b51667b5ba74fc5a28172e251c9ba4c0398e32	Mar 3 2019, 8:32 AM	★	★