Use LauncherUrlWithoutIcon data role where the icon is not needed, and
get LauncherUrl procedurally where it is.
This is a version of D1921 that avoids breaking the writing of the
fallback icon to config.
Details
Details
Diff Detail
Diff Detail
- Repository
- R119 Plasma Desktop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Maybe it should have been the other way around, LauncherUrlWithIcon where needed ;-)
(it seems the icon is only rarely needed)
| applets/taskmanager/package/contents/ui/ContextMenu.qml | ||
|---|---|---|
| 225 | Is it expected that requestRemoveLauncher is "without icon" and requestAddLauncher is "with icon"? Seems asymmetric but I don't know enough about this to know if it's ok or not. | |
| applets/taskmanager/package/contents/ui/ContextMenu.qml | ||
|---|---|---|
| 225 | It's ok because requestRemoveLauncher() (and for that matter launcherPosition()) will ignore the icon data when comparing URLs to remove them. It has to because window icons can change at runtime, so the disk-stored string-encoded icon for a launcher might be different from what the window has currently, but since it's still the same app, we do want to remove the launcher. | |
Comment Actions
I didn't like "WithIcon" because it sounds like it guarantees handing over an icon, but it's really a fallback - so would have to be LauncherUrlWithFallbackIcon, which is quite a mouthful. I think it's prettier to have LauncherUrl to be the full thing and opt into the restrictions :)