Differential D19297

Use plain color source instead of gradient in KisPresetLivePreviewView
ClosedPublic
Actions

Authored by amedonosova on Feb 25 2019, 11:13 AM.

Details

Reviewers
rempt
Group Reviewers
Krita
Commits
R37:d12bbbe11744: Use plain color source instead of gradient in KisPresetLivePreviewView
Summary

KisPresetLivePreviewView cannot display gradient color source: there is
no resource manager for KisResourcesSnapshot, therefore gradient is
nullptr. That crashes Krita, when it tries to render the preview.

This patch solves the issue by falling back to plain color source for
preset preview rendering.

BUG:385521

Diff Detail

Repository
R37 Krita
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amedonosova created this revision.Feb 25 2019, 11:13 AM
Restricted Application added a reviewer: Krita. · View Herald TranscriptFeb 25 2019, 11:13 AM
Restricted Application added a project: Krita. · View Herald Transcript
amedonosova requested review of this revision.Feb 25 2019, 11:13 AM
rempt accepted this revision.Feb 25 2019, 11:27 AM
This revision is now accepted and ready to land.Feb 25 2019, 11:27 AM
Closed by commit R37:d12bbbe11744: Use plain color source instead of gradient in KisPresetLivePreviewView (authored by amedonosova). · Explain WhyFeb 25 2019, 11:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52521

View Options

libs/ui/widgets/kis_preset_live_preview_view.cpp

Loading...