Differential D19293

i18n: Add context to "Cannot fetch sources"
ClosedPublic
Actions

Authored by aspotashev on Feb 24 2019, 10:37 PM.

Details

Reviewers
apol
Commits
R134:43f8d067aa10: i18n: Add context to "Cannot fetch sources"
Test Plan

none

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
aspotashev created this revision.Feb 24 2019, 10:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2019, 10:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
aspotashev requested review of this revision.Feb 24 2019, 10:37 PM
apol accepted this revision.Feb 25 2019, 12:14 AM
apol added a subscriber: apol.

Looks good to me, maybe it would make sense to include the context on the rest? Why is this one special?

This revision is now accepted and ready to land.Feb 25 2019, 12:14 AM
aspotashev added a comment.Feb 25 2019, 12:15 PM

This one is special because it's very unclear without context: one may think "sources" stands for source code, at least Ukrainian translation proves this theory. Other error messages are probably not ambiguous.

Closed by commit R134:43f8d067aa10: i18n: Add context to "Cannot fetch sources" (authored by aspotashev). · Explain WhyFeb 25 2019, 12:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 52525

View Options

libdiscover/backends/PackageKitBackend/PackageKitMessages.cpp

Loading...