Differential D19292

collectionattributetest: small cleanups
ClosedPublic
Actions

Authored by dfaure on Feb 24 2019, 10:36 PM.

Details

Reviewers
dvratil
Commits
R165:bb50935bd15f: collectionattributetest: small cleanups
Summary
  • Don't fail with "duplicate collection" errors after a failure in one

of the tests, properly cleanup

  • Avoid "no such collection" warning due to knut modifying the

collection after we deleted it

  • Fix typo in method name
Test Plan

test still passes

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure requested review of this revision.Feb 24 2019, 10:36 PM
dfaure created this revision.
dvratil requested changes to this revision.Feb 25 2019, 12:50 PM
dvratil added inline comments.
autotests/libs/collectionattributetest.cpp
129

There's AkScopeGuard in src/shared that you can use for this.

This revision now requires changes to proceed.Feb 25 2019, 12:50 PM
dvratil accepted this revision.Feb 25 2019, 1:18 PM

Never mind, I haven't realized the AkScopeGuard is on one of my branches, and not in master yet :)

This revision is now accepted and ready to land.Feb 25 2019, 1:18 PM
Closed by commit R165:bb50935bd15f: collectionattributetest: small cleanups (authored by dfaure). · Explain WhyFeb 28 2019, 8:43 AM
This revision was automatically updated to reflect the committed changes.
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 28 2019, 8:43 AM

Revision Contents
Changeset List

Diff 52796

View Options

autotests/libs/collectionattributetest.h

Loading...
View Options

autotests/libs/collectionattributetest.cpp

Loading...