Removal of log blend mode

Authored by Reptorian on Feb 21 2019, 4:26 PM.


Group Reviewers
R37:922cdf19109e: Remove the log blend mode

While I have been experimenting with log blend mode, and seeing what changes does. I noticed that if you change the color dodge formula to log2(src/dst+1), it becomes the same as the original color dodge formula, and if you utilize the illusionbanks, effectbank version of logarithmic dodge, it becomes really dark, and finally, with log2(src/dst), the result can be extremely dark or light making it useless. So, my decision is to remove those blend modes as they are not savalgeable nor I was able to get something similar to effectbank variation of logarithmic blend without going below 0 and over 1.

Test Plan

Removing Blending Modes

Diff Detail

R37 Krita
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
Reptorian created this revision.Feb 21 2019, 4:26 PM
Restricted Application added a reviewer: Krita. · View Herald TranscriptFeb 21 2019, 4:26 PM
Restricted Application added a project: Krita. · View Herald Transcript
Reptorian requested review of this revision.Feb 21 2019, 4:26 PM
rbreu added a subscriber: rbreu.Feb 21 2019, 8:24 PM

It doesn't crash! This is a comparison between normal dogde (left) and logarithmi dogd (right). I have no idea if this is correct. Burn is analogous, in that the logarithmic version turns out very black.

Reptorian added a comment.EditedFeb 21 2019, 8:59 PM

I see it going very bright on 16f, but smoother on lightened area and darker on 8i. Easy Dodge/Burn are more consistent in their behavior. I think that they are correct.

EDIT - I might take a look to see if I can improve them though.

Reptorian updated this revision to Diff 52345.Feb 22 2019, 10:04 PM
Reptorian retitled this revision from Fix to logarithmic blending mode to Removal of log blend mode.
Reptorian edited the summary of this revision. (Show Details)
Reptorian edited the test plan for this revision. (Show Details)

Decided to remove those blend mode, see first post as to reasons why. It cannot be saved.

rempt accepted this revision.Feb 23 2019, 8:25 AM
rempt added a subscriber: rempt.


This revision is now accepted and ready to land.Feb 23 2019, 8:25 AM
This revision was automatically updated to reflect the committed changes.