Differential D19203

ColumnView and partial C++ refactor of PageRow
ClosedPublic
Actions

Authored by mart on Feb 21 2019, 3:12 PM.

Details

Reviewers

nicolasfella

Group Reviewers

Kirigami

Commits

R169:c0f2a341a4c9: ColumnView and partial C++ refactor of PageRow

Summary

ColumnView is a container component which encapsulates most of the logic from PageRow
(minus the instantiation of components from paths which stays in PageRow)
with that, new features are possible, such as having expanded pages which aren't the last one
or inserting/removing arbitrary pages, to make it behave not like a stack.
This solves also some glitches as ListView is quite buggy.

Test Plan

tested with Kirigmai Gallery and some other apps such as the new PureMaps which needs some of
the new features.
By normal usage, no visual change should occur.

Diff Detail

Repository

R169 Kirigami

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mart created this revision.Feb 21 2019, 3:12 PM

Restricted Application added a project: Kirigami. · View Herald TranscriptFeb 21 2019, 3:12 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

mart requested review of this revision.Feb 21 2019, 3:12 PM

Harbormaster completed remote builds in B8632: Diff 52211.Feb 21 2019, 3:12 PM

a bit more drag distance to be sure not to conflict with horizontal
preventStealing attached property
hide items when removed
fix item position mapping
signal the visible items when forgetting one
update currentItem too when removing items
Merge branch 'master' into mart/columnsView

Harbormaster completed remote builds in B8968: Diff 52799.Feb 28 2019, 11:09 AM

Works fine with KDE Connect

This revision is now accepted and ready to land.Feb 28 2019, 12:02 PM

Closed by commit R169:c0f2a341a4c9: ColumnView and partial C++ refactor of PageRow (authored by mart). · Explain WhyFeb 28 2019, 12:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/CMakeLists.txt (1 line)
A	M	src/columnview.h (408 lines)
A	M	src/columnview.cpp (1276 lines)
A	M	src/columnview_p.h (89 lines)
M		src/controls/Page.qml (16 lines)
M		src/controls/PageRow.qml (596 lines)
M		src/controls/private/ActionButton.qml (8 lines)
M		src/kirigamiplugin.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52211	023c6ea		Feb 21 2019, 3:12 PM	★	★
Diff 2	52799	938b79b	- a bit more drag distance to be sure not to conflict with horizontal	Feb 28 2019, 11:09 AM	★	★
Diff 3	52803	938b79b	R169:c0f2a341a4c9e947cbb2ca914ba36a31728b05c4	Feb 28 2019, 12:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
b4d7c39203ac	f63974a19372	b3408a781713 938b79be2421	Marco Martin	Merge branch 'master' into mart/columnsView	Feb 28 2019, 11:09 AM
b3408a781713	3951f7494982	9a11adb97114	Marco Martin	update currentItem too when removing items	Feb 28 2019, 10:17 AM
9a11adb97114	6493c31e72b6	88330413b08f	Marco Martin	signal the visible items when forgetting one	Feb 27 2019, 3:00 PM
88330413b08f	a4cadde4547e	938204c1d6d8	Marco Martin	fix item position mapping	Feb 25 2019, 11:56 AM
938204c1d6d8	c09b1909e2ed	3c494d0139c3	Marco Martin	hide items when removed	Feb 25 2019, 10:44 AM
3c494d0139c3	03a1b6f9f150	00d57329923d	Marco Martin	preventStealing attached property (Show More…)	Feb 25 2019, 10:42 AM
00d57329923d	8e5af307477f	e05492c605dd	Marco Martin	a bit more drag distance to be sure not to conflict with horizontal flicklables	Feb 25 2019, 10:18 AM
e05492c605dd	15bfd014e198	ce52bb71f76d	Marco Martin	more docs	Feb 21 2019, 1:21 PM
ce52bb71f76d	f94c3affb6f0	aa82603ee81a	Marco Martin	only update currentIndex with push()	Feb 21 2019, 1:13 PM
aa82603ee81a	eb68e314b812	0858743c290d	Marco Martin	wrap insertPage, removePage, movePage and the signals (Show More…)	Feb 21 2019, 12:20 PM
0858743c290d	d7614aee53f3	ae028ad5b9b0	Marco Martin	better sliding to current logic (Show More…)	Feb 21 2019, 11:06 AM
ae028ad5b9b0	65d772d272a3	9c7bf5901895	Marco Martin	support for arrays for properties in push	Feb 20 2019, 2:00 PM
9c7bf5901895	273f04f1959c	e02b08b4b571	Marco Martin	return the popped page	Feb 20 2019, 12:24 PM
e02b08b4b571	bcbbd5611636	5d1200b15eee	Marco Martin	update docs to deletion policy	Feb 20 2019, 12:20 PM
5d1200b15eee	316df4052f53	aef0705bd4cf	Marco Martin	return the item just removed	Feb 20 2019, 9:49 AM
aef0705bd4cf	3c538df6374e	ebdf7fc332d6	Marco Martin	level -> index	Feb 20 2019, 9:43 AM
ebdf7fc332d6	12189e38ee93	9bcccb3c8eb1	Marco Martin	documentation++	Feb 19 2019, 5:42 PM
9bcccb3c8eb1	583d2876cc46	84ccc0fab4b3	Marco Martin	use only polish, to compless layoutItems	Feb 19 2019, 12:39 PM
84ccc0fab4b3	08035067440e	ee52ab8fa26f	Marco Martin	sync m_items and childItems	Feb 19 2019, 11:56 AM
ee52ab8fa26f	c33b011f3a13	07d001e7b7ed	Marco Martin	first support for reordering by models	Feb 19 2019, 10:39 AM
07d001e7b7ed	8955441ed354	7e70acb3dcaa	Marco Martin	replace depth with count	Feb 18 2019, 10:33 AM
7e70acb3dcaa	a3b7fccf2e1a	60ea33fcbd41	Marco Martin	provide firstVisibleItem and lastVisibleItem	Feb 18 2019, 10:19 AM
60ea33fcbd41	4f7bef917bc7	fe4d2b03d112	Marco Martin	rename ColumnsView -> ColumnView	Feb 14 2019, 3:41 PM
fe4d2b03d112	94d93a55213c	5e280a30398f	Marco Martin	ns->containsItem, warnings--	Feb 14 2019, 3:21 PM
5e280a30398f	a075bd905ba8	70a3ce41f6e0	Marco Martin	fix the visibleItems list	Feb 14 2019, 3:17 PM
70a3ce41f6e0	2a1d70c33a31	6ddde7b7845c	Marco Martin	wire separatorVisible to PageRow	Feb 14 2019, 2:16 PM
6ddde7b7845c	d099db7d7fe6	06f823943e99	Marco Martin	finish separators	Feb 14 2019, 2:08 PM
06f823943e99	31bbec8d8416	f29d6912032c	Marco Martin	better behavior for separators	Feb 14 2019, 12:20 PM
f29d6912032c	65a74a22ea26	676d0213a6df	Marco Martin	correctly bind duration and gridUnit	Feb 14 2019, 10:49 AM
676d0213a6df	0e944566050e	0b8835376bdc	Marco Martin	fix push behavior	Feb 11 2019, 6:09 PM
0b8835376bdc	56f00221bfda	6b361bfc96b3 023c6ea87366	Marco Martin	Merge branch 'master' into mart/columnsView	Feb 11 2019, 5:45 PM
6b361bfc96b3	ac14a4fa5c53	0bfa64fcc4e7	Marco Martin	scroll indicator done	Feb 7 2019, 1:15 PM
0bfa64fcc4e7	c5c0844168a0	904d043e4ec5	Marco Martin	very rough scroll indicator	Feb 6 2019, 7:36 PM
904d043e4ec5	b62684496c31	d84229094e6e	Marco Martin	start to remove the old ListView stuff	Feb 5 2019, 6:49 PM
d84229094e6e	09ddcca461b3	d6bdbc9f3ef1	Marco Martin	rough separator instantiation	Feb 5 2019, 5:59 PM
d6bdbc9f3ef1	1cd5e87d9d27	d96f9096e929	Marco Martin	in layoutItems animate scrolling when needed	Feb 5 2019, 5:35 PM
d96f9096e929	0cdbd57e9a62	816feef3b0e8	Marco Martin	remove debug output	Feb 5 2019, 5:20 PM
816feef3b0e8	b2bde1044f28	08b1ce94efcb	Marco Martin	fix page switching	Feb 5 2019, 5:14 PM
08b1ce94efcb	68f8eae0f766	9fe4e43ed3e7	Marco Martin	properly support pop	Feb 5 2019, 3:09 PM
9fe4e43ed3e7	e40536bf0a52	2190f1c230c1	Marco Martin	first prototype of PageRow port to ColumnsView	Feb 4 2019, 9:39 PM
2190f1c230c1	7a22b199250d	459edabbb55c	Marco Martin	instantiate qml kirigami components (Show More…)	Feb 1 2019, 5:31 PM
459edabbb55c	26e71058e336	21c534376c82	Marco Martin	show current item after switch to single page mode	Feb 1 2019, 4:16 PM
21c534376c82	4da028268fcc	2fb919e3ac85	Marco Martin	fix dynamic sizing behavior	Feb 1 2019, 3:54 PM
2fb919e3ac85	0d2bb96dfe49	d70839861904	Marco Martin	expose scroll animation duration	Feb 1 2019, 3:36 PM
d70839861904	2dd85fa506e2	85cf2cce6e38	Marco Martin	expose interactive	Feb 1 2019, 2:32 PM
85cf2cce6e38	aaa076bbc752	f5c0dc514583	Marco Martin	expose contentX/contentWidth	Feb 1 2019, 2:17 PM
f5c0dc514583	8abe8eb7ab04	8d311a1f76dd	Marco Martin	export dragging property	Feb 1 2019, 12:19 PM
8d311a1f76dd	90a517ee5ea7	7cc00d6fdae8	Marco Martin	fix dragging logic (Show More…)	Feb 1 2019, 10:11 AM
7cc00d6fdae8	ef00e5901f80	d8da415e8ff1	Marco Martin	support mouseareas' preventStealing	Jan 31 2019, 5:28 PM
d8da415e8ff1	17230a0132d2	4c7718e5faaa	Marco Martin	filter child events as well	Jan 31 2019, 5:25 PM
4c7718e5faaa	67beecbd72a3	7e21d340e339	Marco Martin	use polish to minimize relayouts	Jan 31 2019, 4:17 PM
7e21d340e339	51f92a31ea2a	3076c3517bd3	Marco Martin	reservedSpace in the attached property	Jan 31 2019, 2:25 PM
3076c3517bd3	28da84aafa89	2ea97fc29bd2	Marco Martin	finish up the attached property	Jan 31 2019, 11:55 AM
2ea97fc29bd2	809620cd0d54	d8e2904b43c8	Marco Martin	beginning of attached properties	Jan 30 2019, 6:24 PM
d8e2904b43c8	353ea81abcdd	7584bffb358a	Marco Martin	update the currentindex/item depending from scrolling	Jan 23 2019, 4:16 PM
7584bffb358a	d9d075e5ea0b	afab075c76f5	Marco Martin	make sure all items in contentitem are taken into account	Jan 23 2019, 12:10 PM
afab075c76f5	39fd066a20c9	845855960b74	Marco Martin	support repeaters (Show More…)	Jan 23 2019, 11:42 AM
845855960b74	aff844f8b177	072103fae3d0	Marco Martin	insert and move operations	Jan 23 2019, 11:03 AM
072103fae3d0	d74abfe0145b	e69f4855bfa0	Marco Martin	appendItem,insertItem,clear	Jan 22 2019, 4:47 PM
e69f4855bfa0	36fe68c3c96f	af702fe785d0	Marco Martin	better snapping	Jan 22 2019, 2:51 PM
af702fe785d0	41624fa298f7	ad184ba481f2	Marco Martin	first prototype of a partial C++ rewrite of PageRow	Jan 22 2019, 11:56 AM