Details

Reviewers

Commits

R4:21810db29e0b: Add a migrator for converting tags to context items

Summary

This migrator creates one context item for each context tag,
then associates the tasks with those contexts.

The tags are just left there. This makes a temporary downgrade possible,
as well as making it possible to rerun the migrator if a bug is found and fixed.

Test Plan

New unittest passes.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

dfaure requested review of this revision.Feb 21 2019, 9:09 AM

dfaure created this revision.

Harbormaster completed remote builds in B8621: Diff 52191.Feb 21 2019, 9:09 AM

Rename method; actually call the migrator class from the migrator app.

Harbormaster completed remote builds in B8657: Diff 52248.Feb 21 2019, 10:14 PM

Fix issue on computers with new-style contexts and no kconfig key.
Simplify code by removing the unnecessary hash.

Harbormaster completed remote builds in B8660: Diff 52254.Feb 21 2019, 10:58 PM

ervin accepted this revision.Mar 2 2019, 10:30 AM

This revision is now accepted and ready to land.Mar 2 2019, 10:30 AM

push v2 (scripted)

Harbormaster completed remote builds in B9074: Diff 52969.Mar 2 2019, 12:31 PM

ervin accepted this revision.Mar 2 2019, 3:28 PM

Closed by commit R4:21810db29e0b: Add a migrator for converting tags to context items (authored by dfaure). · Explain WhyMar 2 2019, 3:57 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/akonadi/akonadistorage.h (2 lines)
M		src/akonadi/akonadistorage.cpp (10 lines)
M		src/zanshin/migrator/CMakeLists.txt (1 line)
P		src/zanshin/migrator/main.cpp (20 lines) Copied to src/zanshin/migrator/zanshincontextitemsmigrator.h
P		src/zanshin/migrator/zanshincontextitemsmigrator.h (49 lines) Copied from src/zanshin/migrator/main.cpp
A	M	src/zanshin/migrator/zanshincontextitemsmigrator.cpp (147 lines)
M		tests/units/migrator/CMakeLists.txt (5 lines)
M		tests/units/migrator/testenv/data/testdata.xml (8 lines)
A	M	tests/units/migrator/zanshincontextitemsmigrationtest.cpp (230 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	52191	f72e412		Feb 21 2019, 9:09 AM	★	★
Diff 2	52248	f72e412	Rename method; actually call the migrator class from the migrator app.	Feb 21 2019, 10:14 PM	★	★
Diff 3	52254	f72e412	Fix issue on computers with new-style contexts and no kconfig key.	Feb 21 2019, 10:58 PM	★	★
Diff 4	52969	364eda1	push v2 (scripted)	Mar 2 2019, 12:31 PM	★	★
Diff 5	53003	3d8849c	R4:21810db29e0b020b17139a48e5b9542d7d8ecd02	Mar 2 2019, 3:57 PM	★	★

Add a migrator for converting tags to context items
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 53003

src/akonadi/akonadistorage.h

src/akonadi/akonadistorage.cpp

src/zanshin/migrator/CMakeLists.txt

src/zanshin/migrator/main.cpp

src/zanshin/migrator/zanshincontextitemsmigrator.h

src/zanshin/migrator/zanshincontextitemsmigrator.cpp

tests/units/migrator/CMakeLists.txt

tests/units/migrator/testenv/data/testdata.xml

tests/units/migrator/zanshincontextitemsmigrationtest.cpp

Add a migrator for converting tags to context itemsClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 53003

src/akonadi/akonadistorage.h

src/akonadi/akonadistorage.cpp

src/zanshin/migrator/CMakeLists.txt

src/zanshin/migrator/main.cpp

src/zanshin/migrator/zanshincontextitemsmigrator.h

src/zanshin/migrator/zanshincontextitemsmigrator.cpp

tests/units/migrator/CMakeLists.txt

tests/units/migrator/testenv/data/testdata.xml

tests/units/migrator/zanshincontextitemsmigrationtest.cpp

Add a migrator for converting tags to context items
ClosedPublic
Actions

Revision Contents
Changeset List