Port Akonadi::ContextRepository to the new serializer methods.
This required passing a DataSource to create(), which has impact all the
way up to the GUI, which now needs to request a data source from the
user when creating a context.
Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Couples of comments, but they are for different commits, they don't need to be done in this commit.
| src/widgets/messageboxinterface.h | ||
|---|---|---|
| 45 | I'd indeed get rid of it if it's unused. | |
| src/widgets/newprojectdialog.h | ||
| 52 | That asks for renaming that class to "NewPageDialog" BTW, likely in a different commit though. | |
| src/widgets/newprojectdialoginterface.h | ||
| 36 | See comment above indeed ;-) | |
| src/widgets/newprojectdialog.h | ||
|---|---|---|
| 52 | I agree on renaming, but I'm not sure about that name. What if one day we add a different kind of page? How about NameAndDataSourceDialog? That's what it really is. | |