Differential D18976

Improve Contextmenu
ClosedPublic
Actions

Authored by trmdi on Feb 13 2019, 1:51 AM.

Details

Reviewers
mvourlakos
Group Reviewers
Latte Dock
Commits
R878:c893ab3d2281: Improve Contextmenu
Summary
  • Display Dock Settings/Panel Settings instead of View Settings
  • Hide View Settings when configuring
  • Create Alt+A, Alt+S, Alt+L shortcuts for actions.

Diff Detail

Repository
R878 Latte Dock
Lint
Lint Skipped
Unit
Unit Tests Skipped
trmdi created this revision.Feb 13 2019, 1:51 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2019, 1:51 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
trmdi requested review of this revision.Feb 13 2019, 1:51 AM
trmdi edited the summary of this revision. (Show Details)Feb 13 2019, 1:55 AM
mvourlakos added a subscriber: mvourlakos.Feb 13 2019, 7:35 AM
mvourlakos added inline comments.
containmentactions/contextmenu/menu.cpp
85 ↗(On Diff #51563)

this bracket ident needs to be like the one from m_addWidgetsAction

138 ↗(On Diff #51563)

including this like this I think it will faile gettest or return false results for translation strings, a clean approach can be:

QString settingsStr = ( viewType == Latte::Types::DockView ? i18nc("dock settings window", "Dock &Settings...") : i18nc("panel settings window, "Panel &Settings") );

m_configureAction->setText(settingsStr);
trmdi updated this revision to Diff 51573.Feb 13 2019, 8:15 AM
trmdi marked 2 inline comments as done.
mvourlakos accepted this revision.Feb 13 2019, 4:55 PM
This revision is now accepted and ready to land.Feb 13 2019, 4:55 PM
trmdi added a comment.Feb 13 2019, 5:08 PM

Oh, wait...
I've just seen it is disabled unexpectedly. Do you know why ?

mvourlakos added a comment.Feb 13 2019, 5:12 PM
In D18976#411537, @trmdi wrote:

Oh, wait...
I've just seen it is disabled unexpectedly. Do you know why ?

yes, it comes from the setVisible(false) I dont know why,
this is why I wanted to add in there:

setEnabled(true);
trmdi updated this revision to Diff 51613.Feb 13 2019, 5:32 PM
Closed by commit R878:c893ab3d2281: Improve Contextmenu (authored by trmdi, committed by mvourlakos). · Explain WhyFeb 13 2019, 5:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 51573

View Options

containmentactions/contextmenu/menu.cpp

Loading...