Details
- Reviewers
jjazeix - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T9800: Lang activity, improve overall layout
Diff Detail
- Repository
- R2 GCompris
- Branch
- lang
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 9099 Build 9117: arc lint + arc unit
Thank you for the patch.
Can you please provide more information on what is fixed? The original issue had 2 issues (with screenshots to better understanding). It would make reviewers gain more time to see the fix and know what has changed without having to apply the patch.
It seems the first point have been fixed (override of the score) but not the second point, is it expected?
@jjazeix The second issue also had been fixed
As the issue 2 , the bar was overriding the last option https://pasteboard.co/HGSCFl7.png
But it has been fixed now ( https://pasteboard.co/I0RdhS6.png )( https://pasteboard.co/I0ReGQ2.png )
The following overriding issues have been fixed :
1 . Bar overrides the last option. https://pasteboard.co/HGSCFl7.png
After fixing this issue https://ibb.co/XtMNPVJ
- In the vertical mode the Ok button is not visible. https://ibb.co/wBmcFLw
After fixing this issue https://ibb.co/71451p5
Committed in https://commits.kde.org/gcompris/14aace02d26d8ac711b5b8e90098fe3f70ba51db with small changes, thank you!