Differential D1888

[startkde] Call KSplash dbus after checking for kinit
ClosedPublic
Actions

Authored by broulik on Jun 15 2016, 9:26 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:3955e784f179: [startkde] Call KSplash dbus after checking for kinit
R871:3955e784f179: [startkde] Call KSplash dbus after checking for kinit
Summary

The check was supposed to check whether kinit would start and exit otherwise.
By badding the qdbus call inbetween, it would check for that one and if no ksplash was running the exit code would be non zero aborting startup.

Test Plan

Literally none.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 4491.Jun 15 2016, 9:26 AM
broulik retitled this revision from to [startkde] Call KSplash dbus after checking for kinit.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma. · View Herald TranscriptJun 15 2016, 9:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Jun 15 2016, 9:29 AM
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a subscriber: davidedmundson.

+++++

This revision is now accepted and ready to land.Jun 15 2016, 9:29 AM
Closed by commit R120:3955e784f179: [startkde] Call KSplash dbus after checking for kinit (authored by broulik). · Explain WhyJun 15 2016, 9:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mstartkde/startkde.cmake (3 lines)
Mstartkde/startplasma.cmake (3 lines)

Diff 4492

View Options

startkde/startkde.cmake

Loading...
View Options

startkde/startplasma.cmake

Loading...