[Containment Actions Configuration] Fix changing plugin
ClosedPublic

Authored by broulik on Fri, Feb 8, 8:58 AM.

Details

Summary

The index argument of the activated signal shadows the index context property of the Repeater

Test Plan

5.15
Changed mouse action plugin in dropdown, Apply button got enabled, could apply setting fine.

(That initialized bool seems to be a remnant from before we used activated but let's just not change that for stable and address this separately)

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Fri, Feb 8, 8:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Feb 8, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Fri, Feb 8, 8:58 AM
broulik edited the test plan for this revision. (Show Details)
davidedmundson added inline comments.
desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
98

would just explicitly using "pluginsCombo.index" also work?

broulik added inline comments.Fri, Feb 8, 9:30 AM
desktoppackage/contents/configuration/ConfigurationContainmentActions.qml
98

No, because index is a "magic" context property set by the Repeater, there is no "physical" property you can access on an element.

davidedmundson accepted this revision.Fri, Feb 8, 9:55 AM
This revision is now accepted and ready to land.Fri, Feb 8, 9:55 AM
This revision was automatically updated to reflect the committed changes.