The default setting is "No Rule", not "All".
AbandonedPublic
Actions

Authored by dfaure on Jun 14 2016, 2:10 PM.

Details

Reviewers

mlaurent
svuorela

Summary

Since Qt 5.4, the default setting for a category can be "off" for some levels
(typically Debug). So saying "All" is very confusing.

Test Plan

the combos now show "No Rule" ;)

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

dfaure retitled this revision from to The default setting is "No Rule", not "All"..

dfaure updated this object.

dfaure edited the test plan for this revision. (Show Details)

dfaure added a reviewer: mlaurent.

svuorela edited edge metadata.

This revision is now accepted and ready to land.Jun 16 2016, 4:10 PM

This change is wrong; I misunderstood how this app works (it actually enables everything when launching it for the first time).

			Path	Packages
M			src/categorytypecombobox.cpp (4 lines)

Commit	Tree	Parents	Author	Summary	Date
6e6658c149af	a0ac1496868f	79ac4bc8d78b	David Faure	The default setting is "No Rule", not "All". (Show More…)	Jun 14 2016, 2:06 PM

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	4462	79ac4bc		Jun 14 2016, 2:10 PM	★	★